Re: [PATCH] powerpc: ibmveth: Harden driver initilisation for kexec

[Jeff Garzik <jgarzik@xxxxxxxxx>]

Santiago Leon wrote:
> From: Michael Ellerman <michael@xxxxxxxxxxxxxx>
>
> After a kexec the veth driver will fail when trying to register with the
> Hypervisor because the previous kernel has not unregistered.
>
> So if the registration fails, we unregister and then try again.
>
> Signed-off-by: Michael Ellerman <michael@xxxxxxxxxxxxxx>
> Acked-by: Anton Blanchard <anton@xxxxxxxxx>
> Signed-off-by: Santiago Leon <santil@xxxxxxxxxx>
> ---
>
>  drivers/net/ibmveth.c |   32 ++++++++++++++++++++++++++------
>  1 files changed, 26 insertions(+), 6 deletions(-)
>
> Looks good to me, and has been around for a couple of months.

This seems completely bonkers to me:

	are resources available?
	if no
		free resources
		try again

It makes resource checking pointless.

	Jeff



-
: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html