+ arch-x86-platform-geode-net5501c-change-active_low-to-0-for-led-driver.patch added to -mm tree
The patch titled
Subject: arch/x86/platform/geode/net5501.c: change active_low to 0 for LED driver
has been added to the -mm tree. Its filename is
arch-x86-platform-geode-net5501c-change-active_low-to-0-for-led-driver.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Bjarke Istrup Pedersen <gurligebis@xxxxxxxxxx>
Subject: arch/x86/platform/geode/net5501.c: change active_low to 0 for LED driver
It seems that there was an error with the active_low = 1 for the
LED, since it should be set to 0 (meaning that active is high,
since 0 is false, hence the confusion.
The wiki article about it confuses it, since it contradicts itself,
regarding what turns on the LED.
I have tested 3.4-rc2 on my net5501 with this patch, and it makes the LED
behave correctly, where "none" turns it off, and "default-on" turns it on,
when echoed onto the trigger "file" in /sys/class/leds.
Signed-off-by: Bjarke Istrup Pedersen <gurligebis@xxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
Cc: Philip Prindeville <philipp@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
arch/x86/platform/geode/net5501.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN arch/x86/platform/geode/net5501.c~arch-x86-platform-geode-net5501c-change-active_low-to-0-for-led-driver arch/x86/platform/geode/net5501.c
--- a/arch/x86/platform/geode/net5501.c~arch-x86-platform-geode-net5501c-change-active_low-to-0-for-led-driver
+++ a/arch/x86/platform/geode/net5501.c
@@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] =
.name = "net5501:1",
.gpio = 6,
.default_trigger = "default-on",
- .active_low = 1,
+ .active_low = 0,
},
};
_
Subject: Subject: arch/x86/platform/geode/net5501.c: change active_low to 0 for LED driver
Patches currently in -mm which might be from gurligebis@xxxxxxxxxx are
arch-x86-platform-geode-net5501c-change-active_low-to-0-for-led-driver.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Newbies FAQ]
[Kernel Archive]
[IETF Annouce]
[DCCP]
[Netdev]
[Networking]
[Security]
[Bugtraq]
[Photo]
[Yosemite]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Linux SCSI]
[Linux Resources]