[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

+ ldm-corrupted-partition-table-can-cause-kernel-oops.patch added to -mm tree



The patch titled
     ldm: corrupted partition table can cause kernel oops
has been added to the -mm tree.  Its filename is
     ldm-corrupted-partition-table-can-cause-kernel-oops.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: ldm: corrupted partition table can cause kernel oops
From: Timo Warns <Warns@xxxxxxxxxxxx>

The kernel automatically evaluates partition tables of storage devices. 
The code for evaluating LDM partitions (in fs/partitions/ldm.c) contains a
bug that causes a kernel oops on certain corrupted LDM partitions.  A
kernel subsystem seems to crash, because, after the oops, the kernel no
longer recognizes newly connected storage devices.

The patch changes ldm_parse_vmdb() to Validate the value of vblk_size.

Signed-off-by: Timo Warns <warns@xxxxxxxxxxxx>
Cc: Eugene Teo <eugeneteo@xxxxxxxxx>
Acked-by: Richard Russon <ldm@xxxxxxxxxxx>
Cc: Harvey Harrison <harvey.harrison@xxxxxxxxx>
Cc: <stable@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 fs/partitions/ldm.c |    5 +++++
 1 file changed, 5 insertions(+)

diff -puN fs/partitions/ldm.c~ldm-corrupted-partition-table-can-cause-kernel-oops fs/partitions/ldm.c
--- a/fs/partitions/ldm.c~ldm-corrupted-partition-table-can-cause-kernel-oops
+++ a/fs/partitions/ldm.c
@@ -251,6 +251,11 @@ static bool ldm_parse_vmdb (const u8 *da
 	}
 
 	vm->vblk_size     = get_unaligned_be32(data + 0x08);
+	if (vm->vblk_size == 0) {
+		ldm_error ("Illegal VBLK size");
+		return false;
+	}
+
 	vm->vblk_offset   = get_unaligned_be32(data + 0x0C);
 	vm->last_vblk_seq = get_unaligned_be32(data + 0x04);
 
_

Patches currently in -mm which might be from Warns@xxxxxxxxxxxx are

ldm-corrupted-partition-table-can-cause-kernel-oops.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Linux Resources]

Add to Google Powered by Linux