Re: [PATCH 06/12] MIPS: Netlogic: early console fix

[Florian Fainelli <florian@xxxxxxxxxxx>]

On Friday 13 July 2012 21:53:19 Jayachandran C wrote:
> In prom_putchar(), wait for just the TX empty bit to clear in the
> UART LSR.
> 
> Signed-off-by: Jayachandran C <jayachandranc@xxxxxxxxxxxxxxxxx>
> ---
>  arch/mips/netlogic/common/earlycons.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/netlogic/common/earlycons.c 
b/arch/mips/netlogic/common/earlycons.c
> index f193f7b..53b200a5 100644
> --- a/arch/mips/netlogic/common/earlycons.c
> +++ b/arch/mips/netlogic/common/earlycons.c
> @@ -54,7 +54,7 @@ void prom_putchar(char c)
>  #elif defined(CONFIG_CPU_XLR)
>  	uartbase = nlm_mmio_base(NETLOGIC_IO_UART_0_OFFSET);
>  #endif
> -	while (nlm_read_reg(uartbase, UART_LSR) == 0)
> +	while ((nlm_read_reg(uartbase, UART_LSR) & 0x20) == 0)
>  		;

You could use use UART_LSR_THRE here instead of 0x20.
--
Florian