Re: [PATCH v4,04/10] Add the MIPS32R2 'ins' and 'ext' instructions for use by the kernel's micro-assembler.

[Sergei Shtylyov <sshtylyov@xxxxxxxxxx>]

Hello.

On 29-06-2012 22:35, Steven J. Hill wrote:

> From: "Steven J. Hill"<sjhill@xxxxxxxx>

> Signed-off-by: Steven J. Hill<sjhill@xxxxxxxx>
[...]

> diff --git a/arch/mips/mm/uasm.c b/arch/mips/mm/uasm.c
> index 5fa1851..663b6b1 100644
> --- a/arch/mips/mm/uasm.c
> +++ b/arch/mips/mm/uasm.c
[...]
> @@ -343,6 +345,13 @@ Ip_u2u1msbu3(op)					\
>   }							\
>   UASM_EXPORT_SYMBOL(uasm_i##op);
>
> +#define I_u2u1mmsbu3(op) 				\
> +Ip_u2u1msbu3(op)					\
> +{							\
> +	build_insn(buf, insn##op, b, a, d-1, c);	\
> +}							\
> +UASM_EXPORT_SYMBOL(uasm_i##op);
> +
>   #define I_u1u2(op)					\
>   Ip_u1u2(op)						\
>   {							\
> @@ -396,6 +405,8 @@ I_u2u1u3(_drotr)
>   I_u2u1u3(_drotr32)
>   I_u3u1u2(_dsubu)
>   I_0(_eret)
> +I_u2u1mmsbu3(_ext)
> +I_u2u1msbu3(_ins)

   Not I_u2u1mmsbu3()?

WBR, Sergei