Re: [PATCH] MIPS: Add emulation for fpureg-mem unaligned access

[Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>]

On Sat, Jun 16, 2012 at 02:58:47PM +0200, Lluís Batlle i Rossell wrote:
> Hello again,
> 
> On Sat, Jun 16, 2012 at 02:15:13PM +0200, Lluís Batlle i Rossell wrote:
> > > From what I can tell, ldc1 is a valid MIPS32 instruction, so this
> > > should probably be something like
> > > 
> > >         case ld_op:
> > > #ifndef CONFIG_64BIT
> > >                 return sigill;
> > > #endif
> > 
> > I agree! I'll repost with these fixes.
> 
> Well, I think I take my words back. Handling the ldc1/sdc1 cases in MIPS32 is
> tricker than I thought first, because I can't use ldl/ldr or sdl/sdr there.
> Given my ability with mips assembly, I leave the patch as is.
> 
> In 'patchwork' I had set the patch first to superseeded, but then I set it back
> to New.

why is there a reason for this ? Unaligned FPU access shouts to me simply
broken code, go fix that. But maybe I'm wrong ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]