Re: [PATCH v2 5/5] MIPS: Move cache setup to setup_arch().
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On 06/11/2012 09:21 AM, David Daney wrote:
On 06/10/2012 09:16 PM, Shane McDonald wrote:I've run into a problem in linux-3.5-rc1, and I've tracked it down to this patch, MIPS: Move cache setup to setup_arch()., commit 6650df3c380e0db558dbfec63ed860402c6afb2a.Are you permitted to describe the problem in any additional detail? Knowing what type of system is affected and the nature of the problem would be useful in trying to arrive at a good solution.
OK, for some reason I missed this bit... [...]
I'm running a single-CPU, PMC-Sierra RM7035C-based system. Before applying this patch, cca_setup() in arch/mips/mm/c-r4k.c is called before coherency_setup() (called from rk4_cache_init()). After applying the patch, it is called afterwards. Because coherency_setup() relies on cca_setup() properly setting the variable cca, it won't use the value of cca supplied on the kernel command line. I haven't verified it, but I suspect the same problem will occur with the call to setcoherentio(), also in c-r4k.c. Unfortunately, I don't have the knowledge to formulate a patch to this problem, but I wanted to raise the issue. Shane McDonald
I will think about how to fix it. David Daney
[Linux MIPS Home] [LKML Archive] [Linux ARM] [Linux] [Git] [Photo] [Yosemite News] [Linux SCSI] [Linux Hams]