Re: [PATCH] MIPS: Refactor 'clear_page' and 'copy_page' functions.

[David Daney <david.daney@xxxxxxxxxx>]

On 05/24/2012 01:38 PM, Steven J. Hill wrote:
> From: "Steven J. Hill"<sjhill@xxxxxxxx>
>
> Remove usage of the '__attribute__((alias("...")))' hack that aliased
> to integer arrays containing micro-assembled instructions. This hack
> breaks when building a microMIPS kernel. It also makes the code much
> easier to understand.
>
> Signed-off-by: Steven J. Hill<sjhill@xxxxxxxx>

Looks good to (and even works for) me:

Acked-by: David Daney <david.daney@xxxxxxxxxx>

> ---
>   arch/mips/mm/Makefile     |    4 +--
>   arch/mips/mm/page-funcs.S |   49 +++++++++++++++++++++++++++++++++
>   arch/mips/mm/page.c       |   67 ++++++++++++---------------------------------
>   3 files changed, 69 insertions(+), 51 deletions(-)
>   create mode 100644 arch/mips/mm/page-funcs.S