Re: [PATCH v2 1/2] MIPS: fix/enrich 34K APRP (APSP) functionalities
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
Thanks for reviewing the code. On 05/17/2012 08:30 PM, John Crispin wrote:
Hi,diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index ce30e2f..8205afe 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -1925,7 +1925,7 @@ config MIPS_MT_FPAFF config MIPS_VPE_LOADER bool "VPE loader support." - depends on SYS_SUPPORTS_MULTITHREADING + depends on SYS_SUPPORTS_MULTITHREADING&& MIPS_MALTAThis would lead to the second user of the API having to patch this piece of code to make it work. You could introduce a ARCH_HAS_APRP which any platform can then select ?
Hmm... This is a good idea. Maybe the name could be SYS_SUPPORTS_APRP?
I think it would also make sense to split changes to generic and malta code into separate patches if that is possible.
Yes, that's possible. Will do it in the next version. Regards, Deng-Cheng
[Linux MIPS Home] [LKML Archive] [Linux ARM] [Linux] [Git] [Photo] [Yosemite News] [Linux SCSI] [Linux Hams]