Re: [PATCH v2,03/10] MIPS: Add support for the M14K core.
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On Thu, 19 Apr 2012, Steven J. Hill wrote: > diff --git a/arch/mips/include/asm/cpu.h b/arch/mips/include/asm/cpu.h > index ddd8b4a..00e5adf 100644 > --- a/arch/mips/include/asm/cpu.h > +++ b/arch/mips/include/asm/cpu.h > @@ -95,6 +95,7 @@ > #define PRID_IMP_74K 0x9700 > #define PRID_IMP_1004K 0x9900 > #define PRID_IMP_1074K 0x9a00 > +#define PRID_IMP_14K 0x9c00 Here and all over this change -- shouldn't this be spelled M14K rather than 14K just as for M4K vs 4K? I think pretending the M14K is a 14K will cause us unnecessary hassle if an actual 14K is ever made (there's some functional pattern in how the M4K compares to the 4K and then how the transition from the M4K to the M14K has been made; if the 4K RTL is ever ported to microMIPS support one might expect it to be called the 14K, so let's keep the name space clean). Or actually this should even be PRID_IMP_M14KC (and likewise elsewhere throughout) as the M14K has a different PRId -> 0x9b00. Let's keep the naming correct. Maciej
[Linux MIPS Home] [LKML Archive] [Linux ARM] [Linux] [Git] [Photo] [Yosemite News] [Linux SCSI] [Linux Hams]