Re: [PATCH 2/3] MIPS: changes in mm for adding THP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 11/26/2011 06:39 AM, Hillf Danton wrote:
Based on the current work of huge TLB, no code is added for THP but info gcc
to compile the huge TLB code for THP. That is the second factor why the present
bit is selected.

Signed-off-by: Hillf Danton<dhillf@xxxxxxxxx>
---

--- a/arch/mips/include/asm/page.h	Thu Nov 24 21:17:10 2011
+++ b/arch/mips/include/asm/page.h	Sat Nov 26 21:35:51 2011
@@ -33,7 +33,7 @@
  #define PAGE_SIZE	(_AC(1,UL)<<  PAGE_SHIFT)
  #define PAGE_MASK       (~((1<<  PAGE_SHIFT) - 1))

-#ifdef CONFIG_HUGETLB_PAGE
+#if defined(CONFIG_HUGETLB_PAGE) || defined(CONFIG_TRANSPARENT_HUGEPAGE)

This exact sequence happens many times in the patch.

Can we define some symbol (perhaps in page.h) that is set for both of the conditions?

#if defined(CONFIG_HUGETLB_PAGE) || defined(CONFIG_TRANSPARENT_HUGEPAGE)
#define BRFL
#endif
.
.
.

#ifdef BRFL  /* everywhere else */

We of course wouldn't use the name BRFL, but rather something fitting.

With a change like that, I would like to retest the patches and try to get them merged.

David Daney



[Linux MIPS Home]     [LKML Archive]     [Linux ARM]     [Linux]     [Git]     [Photo]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

Add to Google Powered by Linux