Re: [PATCH 1/5] i2c: Convert i2c-octeon.c to use device tree.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


> >>-	if (i2c_data == NULL) {
> >>-		dev_err(i2c->dev, "no I2C frequency data\n");
> >>+	/*
> >>+	 * "clock-rate" is a legacy binding, the official binding is
> >>+	 * "clock-frequency".  Try the official one first and then
> >>+	 * fall back if it doesn't exist.
> >>+	 */
> >>+	data = of_get_property(pdev->dev.of_node, "clock-frequency",&len);
> >>+	if (!data || len != sizeof(*data))
> >>+		data = of_get_property(pdev->dev.of_node, "clock-rate",&len);
> >>+	if (data&&  len == sizeof(*data)) {
> >>+		i2c->twsi_freq = be32_to_cpup(data);
> >
> >Can't you use of_property_read_u32?
> 
> I will investigate, and use it if possible.

Any outcome?

And shouldn't the bindings be documented? Or are they only standard and
we hide the legacy one?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature


[Linux MIPS Home]     [LKML Archive]     [Linux ARM]     [Linux]     [Git]     [Photo]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

Add to Google Powered by Linux