Re: [PATCH] jump-label: initialize jump-label subsystem somewhat later
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On 12/14/2011 08:51 AM, Peter Zijlstra wrote:
On Wed, 2011-12-14 at 08:48 -0800, David Daney wrote:From: David Daney<david.daney@xxxxxxxxxx> commit 97ce2c88f9ad42e3c60a9beb9fca87abf3639faa breaks MIPS. The jump-lable initialization does I-Cache flushing after modifying code. On MIPS this is done by calling through the function pointer flush_icache_range(). This function pointer is initialized mm_init().
Actually I misspoke, for MIPS we need jump_label_init() after trap_init(), not mm_init().
As things stand, we cannot be calling jump_label_init() until after mm_init() completes, so we move the call down to satisfy this constraint.I'm fine as long as it stays before sched_init(), which it does. Jeremy is this still early enough for you?
Just tested a revised patch that moves it to between trap_init() and mm_init(), I propose that we do that instead.
New patch in a couple of minutes. David Daney
[Linux MIPS Home] [LKML Archive] [Linux ARM] [Linux] [Git] [Photo] [Yosemite News] [Linux SCSI] [Linux Hams]