Re: [PATCH 3/6] rb532: do not KSEG1ADDR an already virtual address | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
Hello. Florian Fainelli wrote:
This patch removes the superfluous double KSEG1ADDR against the base register in the setup code. Signed-off-by: Florian Fainelli <florian@xxxxxxxxxxx> --- diff --git a/arch/mips/rb532/setup.c b/arch/mips/rb532/setup.c index 7aafa95..6d3286e 100644 --- a/arch/mips/rb532/setup.c +++ b/arch/mips/rb532/setup.c @@ -10,6 +10,7 @@ #include <linux/ioport.h>#include <asm/mach-rc32434/rc32434.h>+#include <asm/mach-rc32434/rb.h> #include <asm/mach-rc32434/pci.h>struct pci_reg __iomem *pci_reg;@@ -27,7 +28,7 @@ static struct resource pci0_res[] = { static void rb_machine_restart(char *command) { /* just jump to the reset vector */ - writel(0x80000001, (void *)KSEG1ADDR(RC32434_REG_BASE + RC32434_RST)); + writel(0x80000001, (void *)KSEG1ADDR(REG_BASE + RC32434_RST));
Why not just leave RC32434_REG_BASE + RC32434_RST and remove KSEG1ADDR? BTW, the cast could be removed as well, since it's already a part of RC32434_REG_BASE...
WBR, Sergei
[Linux MIPS Home] [Kernel list] [Linux ARM list] [Linux] [Git] [Photo] [Yosemite News] [MIPS Architecture] [Linux SCSI] [Linux Hams] [Site Home]
|
|