Re: [PATCH RESEND] [MIPS]: multi-statement if() seems to be missing braces

[Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>]

On Wed, 14 May 2008 00:25:07 +0100 Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote:

> On Tue, May 13, 2008 at 02:50:50PM +0300, Ilpo J__rvinen wrote:
> 
> > In case this is a genuine bug, somebody else more familiar
> > with that stuff should evaluate it's effects (I just found it
> > by some shell pipeline and it seems suspicious looking).
> 
> Should be fairly as proven by practice; it's there since day of of 64-bit
> pagetable for 32-bit hw support which was November 29, 2004.
> 

It's unlikely that anyone would notice an error in pte_mkyoung().  It
will affect page reclaim behaviour and _might_ be demonstrable with a
carefully set up test.  But an error in here won't cause crashes or
lockups or anything.

What this needs is someone who understands the architecture (ie: you
;)) to take a look, please.