Re: [PATCH] Fix check for valid stack pointer during backtrace

[Atsushi Nemoto <anemo@xxxxxxxxxxxxx>]

On Mon, 12 May 2008 14:59:23 +0200 (CEST), Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> wrote:
> The newly added check for valid stack pointer address breaks at least for
> 64bit kernels.  Use __get_user() for accessing stack content to avoid crashes,
> when doing the backtrace.
> 
> Signed-off-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> ---

Thank you for updating.

> -	unsigned long *sp = (unsigned long *)(reg29 & ~3);
> +	unsigned long __user *sp = (unsigned long __user *)(reg29 & ~3);

Please drop this change, while kstack_end expect non __user pointer.

---
Atsushi Nemoto