Re: Breakage in arch/mips/kernel/traps.c for 64bit

[tsbogend@xxxxxxxxxxxxxxxx (Thomas Bogendoerfer)]

On Sun, May 04, 2008 at 10:39:44PM +0900, Atsushi Nemoto wrote:
> > +	unsigned long __user *sp = (unsigned long __user *)(reg29 & ~3);
> ...
> > +	while (!kstack_end(sp)) {
> > +		if (__get_user(addr, sp++)) {
> 
> This will leads a sparse warning since an argument for kstack_end is 'void *'.
> 
> 	while (!kstack_end((void *)(unsigned long)sp)) {
> 
> will make this part sparse-free, though it seems a bit ugly.

hmm, would leaving sp as unsigned long * and casting it for __get_user()
make sparse happy ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]