Re: Breakage in arch/mips/kernel/traps.c for 64bit

[Atsushi Nemoto <anemo@xxxxxxxxxxxxx>]

On Sun, 4 May 2008 00:48:49 +0200, tsbogend@xxxxxxxxxxxxxxxx (Thomas Bogendoerfer) wrote:
> hmm, why not simply use __get_user() when accessing the stack content ?
> show_stacktrace() already does it for stack dumping ? This would
> avoid any work for whatever sick stack mappings. Below is a patch,
> which does this.

I like this patch.  One minor request:

> +	unsigned long __user *sp = (unsigned long __user *)(reg29 & ~3);
...
> +	while (!kstack_end(sp)) {
> +		if (__get_user(addr, sp++)) {

This will leads a sparse warning since an argument for kstack_end is 'void *'.

	while (!kstack_end((void *)(unsigned long)sp)) {

will make this part sparse-free, though it seems a bit ugly.

---
Atsushi Nemoto