Re: [PATCH 2/2] [MIPS] add DECstation DS1287 clockevent

[Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxx>]

Atsushi Nemoto пишет:
> On Wed, 23 Apr 2008 08:52:45 +0900, Yoichi Yuasa <yoichi_yuasa@xxxxxxxxxxxxxx> wrote:
>> add DECstation DS1287 clockevent
>>
>> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@xxxxxxxxxxxxxx>
> ...
>> --- linux-orig/arch/mips/kernel/Makefile	2008-04-22 19:01:43.957134178 +0900
>> +++ linux/arch/mips/kernel/Makefile	2008-04-22 18:03:05.427649422 +0900
>> @@ -9,8 +9,9 @@ obj-y		+= cpu-probe.o branch.o entry.o g
>>  		   time.o topology.o traps.o unaligned.o
>>  
>>  obj-$(CONFIG_CEVT_BCM1480)	+= cevt-bcm1480.o
>> -obj-$(CONFIG_CEVT_R4K)		+= cevt-r4k.o
>> +obj-$(CONFIG_CEVT_DS1287)	+= cevt-ds1287.o
>>  obj-$(CONFIG_CEVT_GT641XX)	+= cevt-gt641xx.o
>> +obj-$(CONFIG_CEVT_R4K)		+= cevt-r4k.o
>>  obj-$(CONFIG_CEVT_SB1250)	+= cevt-sb1250.o
>>  obj-$(CONFIG_CEVT_TXX9)		+= cevt-txx9.o
>>  obj-$(CONFIG_CSRC_BCM1480)	+= csrc-bcm1480.o
> 
> Why CONFIG_CEVT_R4K line was moved?  The order is important?
> 
>> --- linux-orig/arch/mips/kernel/cevt-ds1287.c	1970-01-01 09:00:00.000000000 +0900
>> +++ linux/arch/mips/kernel/cevt-ds1287.c	2008-04-22 18:03:05.455637018 +0900
> ...
>> +static void ds1287_set_mode(enum clock_event_mode mode,
>> +			    struct clock_event_device *evt)
>> +{
>> +	unsigned long flags;
>> +	u8 val;
>> +
>> +	spin_lock_irqsave(&rtc_lock, flags);
> 
> You do not have to use irqsave here, while set_mode is always called
> with interrupts disabled.  And for rtc_lock ... I don't know if this
> code could be used on SMP :-)
> 

After I had saved a DECstation 5000/200 from a junkyard a few years
ago (very neat hardware, actually), I did some research on this brand.
AFAICT, all MIPS-based DECstation models were UP.

Dmitri