Re: [PATCH] [MIPS] Fix order of BRK_BUG in case

[Ralf Baechle <ralf@xxxxxxxxxxxxxx>]

On Sat, Apr 19, 2008 at 11:16:36PM +0300, Ilpo Järvinen wrote:

> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
> index 984c0d0..4dfcd61 100644
> --- a/arch/mips/kernel/traps.c
> +++ b/arch/mips/kernel/traps.c
> @@ -694,7 +694,7 @@ asmlinkage void do_bp(struct pt_regs *regs)
>  		info.si_addr = (void __user *) regs->cp0_epc;
>  		force_sig_info(SIGFPE, &info, current);
>  		break;
> -	case BRK_BUG:
> +	case BRK_BUG << 10:
>  		die("Kernel bug detected", regs);
                ^^^

Now what will be happening if with your patch applied a "break BRK_BUG"
instruction is executed in userspace?

  Ralf