Re: [PATCH v2 1/2] netfilter: ipvs: Verify that IP_VS protocol has been registered

[Julian Anastasov <ja@xxxxxx>]

	Hello,

On Sat, 14 Apr 2012, Sasha Levin wrote:

> On Sat, Apr 14, 2012 at 1:53 PM, Julian Anastasov <ja@xxxxxx> wrote:
> >        Ops. It seems now we expose old problem when
> > no protocol is configured. As this change probably will
> > go to stable kernels, lets make it correct. Can you
> > remove the defines around register_ip_vs_proto_netns, so
> > that it is always compiled. One that wants to save
> > memory will not disable all protocols. See commit
> > 091bb34c143674d37a59b2d4857534f7106c5d7d for reference.
> 
> Oh, so it wasn't getting built right now at all if we didn't select
> any protocols.
> 
> How about moving those defines down to our loop as well? this way
> everything will behave exactly like it did before.

	Better to remove the defines. It is a misconfiguration
to enable IPVS without protocols. The referenced commit
just tried to remove warnings, not save memory by commenting
unused function. Adding more define makes the things more ugly.

Regards

--
Julian Anastasov <ja@xxxxxx>