Re: [PATCH 5/5] ixgbe: Start temperature sensor attribute index with 1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 23, 2013 at 02:01:58PM +0100, Jean Delvare wrote:
> On Fri, 22 Nov 2013 22:08:01 -0800, Guenter Roeck wrote:
> > Per hwmon ABI, temperature sensor attribute index starts with 1, not 0.
> > 
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> >  drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c |    8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c
> > index 3081974..e74ae36 100644
> > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c
> > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c
> > @@ -118,22 +118,22 @@ static int ixgbe_add_hwmon_attr(struct ixgbe_adapter *adapter,
> >  	case IXGBE_HWMON_TYPE_LOC:
> >  		ixgbe_attr->dev_attr.show = ixgbe_hwmon_show_location;
> >  		snprintf(ixgbe_attr->name, sizeof(ixgbe_attr->name),
> > -			 "temp%u_label", offset);
> > +			 "temp%u_label", offset + 1);
> >  		break;
> >  	case IXGBE_HWMON_TYPE_TEMP:
> >  		ixgbe_attr->dev_attr.show = ixgbe_hwmon_show_temp;
> >  		snprintf(ixgbe_attr->name, sizeof(ixgbe_attr->name),
> > -			 "temp%u_input", offset);
> > +			 "temp%u_input", offset + 1);
> >  		break;
> >  	case IXGBE_HWMON_TYPE_CAUTION:
> >  		ixgbe_attr->dev_attr.show = ixgbe_hwmon_show_cautionthresh;
> >  		snprintf(ixgbe_attr->name, sizeof(ixgbe_attr->name),
> > -			 "temp%u_max", offset);
> > +			 "temp%u_max", offset + 1);
> >  		break;
> >  	case IXGBE_HWMON_TYPE_MAX:
> >  		ixgbe_attr->dev_attr.show = ixgbe_hwmon_show_maxopthresh;
> >  		snprintf(ixgbe_attr->name, sizeof(ixgbe_attr->name),
> > -			 "temp%u_crit", offset);
> > +			 "temp%u_crit", offset + 1);
> >  		break;
> >  	default:
> >  		rc = -EPERM;
> 
> Reviewed-by: Jean Delvare <khali@xxxxxxxxxxxx>
> 
Hi Jean,

thanks a lot for the reviews!

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux