Re: [PATCH] hwmon: (ad7314) Fix build warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Sat, Apr 21, 2012 at 06:15:38AM -0400, Jean Delvare wrote:
> On Sat, 21 Apr 2012 09:18:35 +0200, Jean Delvare wrote:
> > The original code looks a little weird though. Some of the defined
> > constants aren't used, "offset" is used where "shift" should be.
> > Introducing function sign_extend16 would also make the code more
> > readable. I'll send a patch...
> 
> ... or not. My patch makes the binary larger, so it's pointless.
> 
And that after I saved an entire byte on x86_64 with my patch :).

Cleaning up the unused constants makes sense, though. I'll prepare a patch for -next.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Free Singles Community]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]

Add to Google Powered by Linux