- Subject: [PATCH v2 00/15] mark const init data with __initconst instead of __initdata
- From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
- Date: Fri, 30 Mar 2012 22:03:58 +0200
- Cc: Andrew Lunn <andrew@xxxxxxx>, Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>, linux-mips@xxxxxxxxxxxxxx, Tony Lindgren <tony@xxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Matt Porter <mporter@xxxxxxxxxxxxxxxxxxx>, Nicolas Ferre <nicolas.ferre@xxxxxxxxx>, platform-driver-x86@xxxxxxxxxxxxxxx, Grant Likely <grant.likely@xxxxxxxxxxxx>, ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx, Randy Dunlap <rdunlap@xxxxxxxxxxxx>, linux-mtd@xxxxxxxxxxxxxxxxxxx, Sekhar Nori <nsekhar@xxxxxx>, Daniel Walker <dwalker@xxxxxxxxxx>, lm-sensors@xxxxxxxxxxxxxx, Klaus Kudielka <klaus.kudielka@xxxxxxxx>, Kevin Hilman <khilman@xxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxxx>, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>, Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>, Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx>, Lennert Buytenhek <kernel@xxxxxxxxxxxxxx>, Kyungmin Park <kyungmin.park@xxxxxxxxxxx>, David Brown <davidb@xxxxxxxxxxxxxx>, Anatolij Gustschin <agust@xxxxxxx>, Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>, Alexey Dobriyan <adobriyan@xxxxxxxxx>, Joerg Reuter <jreuter@xxxxxxxx>, linux-media@xxxxxxxxxxxxxxx, cbe-oss-dev@xxxxxxxxxxxxxxxx, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx>, linux-arm-msm@xxxxxxxxxxxxxxx, Andreas Koensgen <ajk@xxxxxxxxxxxxxxxxxxxxx>, Henrique de Moraes Holschuh <ibm-acpi@xxxxxxxxxx>, Haojian Zhuang <haojian.zhuang@xxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, linux-samsung-soc@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Barry Song <baohua.song@xxxxxxx>, linux-hams@xxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx, Andrew Victor <linux@xxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, David Howells <dhowells@xxxxxxxxxx>, davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx, Jean-Paul Roubelat <jpr@xxxxxxxxx>, Eric Miao <eric.y.miao@xxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>, linux-ide@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, Nicolas Pitre <nico@xxxxxxxxxxx>, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, Tomasz Stanislawski <t.stanislaws@xxxxxxxxxxx>, Bryan Huntsman <bryanh@xxxxxxxxxxxxxx>, Sascha Hauer <kernel@xxxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, Paul Mackerras <paulus@xxxxxxxxx>, Josh Boyer <jwboyer@xxxxxxxxx>, Shawn Guo <shawn.guo@xxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
- In-reply-to: <20120329211131.GA31250@pengutronix.de>
- User-agent: Mutt/1.5.21 (2010-09-15)
Hello,
On Thu, Mar 29, 2012 at 11:11:31PM +0200, Uwe Kleine-König wrote:
> this series fixes a common error to use __initdata to mark const
> variables. Most of the time this works well enough to go unnoticed
> (though I wonder why the linker doesn't warn about that).
> Just try adding something like
>
> int something __initdata;
>
> to one of the patched files and compile to see the error.
>
> While touching these annotations I also corrected the position where it
> was wrong to go between the variable name and the =.
>
> Note this series is not compile tested.
I now dropped the wrong annotations. So two patches became obsolete
(mtd and percpu). Note that I also dropped fixing the position of
__initdata if changing it to __initconst was wrong. (I think if
__initdata is placed before the variable name it doesn't have any
effect.)
I didn't promote the Acks I got because all acked changes changed in v2.
For the details changed in each patch see the changelogs in the
respective patch mails that I follow up to this mail.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
[Video for Linux]
[Mplayer Users]
[Linux USB Devel]
[Linux Audio Users]
[Photos]
[Yosemite Photos]
[Free Singles Community]
[Linux Kernel]
[Linux SCSI]
[XFree86]
[Yosemite Backpacking]