Re: [Patch] hwmon: (max6639) Set Pulse per revolution loop for both channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Mon, 2012-02-20 at 17:14 -0500, Chris wrote:
> The patches I just submitted fix the main issues with the driver on my
> system. I didn't fix the variable initialization because it seems to
> generate a warning when ever I move them closer to were they belong
> in, it generates a compiler warning of "warning: ISO C90 forbids mixed
> declarations and code". I am looking into how platform_data works to
> see how it works to see if I can handle checking it and changing the
> chip initialization to work with platform data if its provided and to
> leave it alone if its not. Thanks for the patience with my patch
> submissions, I am learning a lot from this

The initializations are not needed.

	s/int i = 0/int i/
	s/int err = 0/int err/

should do it.


> On Mon, Feb 20, 2012 at 1:58 PM, Roland Stigge <stigge@xxxxxxxxx> wrote:
> > Hi!
> >
> > On 02/20/2012 06:39 PM, Guenter Roeck wrote:
> >>> Please resubmit a (-p1) patch fixing the issue your originally spotted
> >>> instead.
> >>>
> >> We really need input from Roland on the initialization problem.
> >> Might make sense to kwwp him copied on this exchange.
> >
> > Thanks for your notification and sorry for the delay!
> >
> > Unfortunately, when I ported the driver from the other original author,
> > I kept the initialization procedure which is obviously wrong, doing
> > initialization only for one channel. (I adjusted the driver locally
> > platform-dependent, so didn't find a chance for mainline integration and
> > this way, the obvious problems in the mainline driver slipped.)
> >
> > Therefore, a fix for doing this for both channels, possibly in a loop,
> > would be good, IMO.
> >
> > Jean's note about the broken variable initialization is correct. Should
> > have done this differently.
> >
> > The other note about initialization only with platform_data is also a
> > good idea.
> >
> > I'm using the chip on a custom ARM board without BIOS initialization,
> > but providing platform_data in this case should be the correct way, anyway.
> >
> > So Chris, if you are already at it, do it this way. Otherwise please
> > notify me and I can prepare patches.
> >
> > Thanks for your work!
> >
> > Roland

lm-sensors mailing list

[Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Free Singles Community]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]

Add to Google Powered by Linux