Re: [Patch] hwmon: (max6639) Set Pulse per revolution loop for both channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, 13 Feb 2012 00:56:00 -0500, Chris wrote:
> Removed initialization to leave bios or hardware defaults alone.

Err, this is going too far. The original author of the code obviously
needed the driver to initialize the chip, otherwise he wouldn't have
defined a platform data for this purpose. Killing the initialization
function altogether makes no sense. All I said was that it seemed
curious to do it all _by default_.

Anyway, this is really a secondary issue at this point. The main
problems is the two functional bugs we spotted in the driver. We should
fix them first, and then we can discuss the rest if there is an
interest. I'm not using this driver and I don't know who is in
practice, so I don't care that much.

Please resubmit a (-p1) patch fixing the issue your originally spotted
instead.

Thanks,
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Free Singles Community]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]

Add to Google Powered by Linux