[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/4] x86-64: fix vclock_gettime()



Petr Tesarik píše v Čt 14. 05. 2009 v 15:06 +0200:
> Now, commit cb9e35dce94a1b9c59d46224e8a94377d673e204 removed
> rdtsc_barrier() from that function, and moved it to
> do_vgettimeofday(). AFAICS the same is also needed for
> vgetns(). So far so good, a one-liner should do, shouldn't it?
> No, it won't do.

Just to make things clear. The vDSO had been broken even before Ingo's
commit, but the commit made the .altinstructions section go away from
vDSO, which made the bug kind of disappear.

I could even argue that the synchronization is not even needed, because
this code path gets used rather often, and nobody has complained so far,
but that's probably not the point...

Petr Tesarik


--
To unsubscribe from this list: send the line "unsubscribe linux-x86_64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Linux ia64]     [Linux Kernel]     [DCCP]     [Linux ARM]     [Linux]     [Photo]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

Add to Google Powered by Linux