RE: [discuss] [PATCH] [40/66] x86_64: Quieten down microcode update driver

["Jin, Gordon" <gordon.jin@xxxxxxxxx>]

ak@xxxxxxx wrote:
> Only log data in microcode driver when something is changed Otherwise
> it was far too noisy on large systems. 
> 
> Also remove the printk when it is unloaded.
> 
> Cc: tigran@xxxxxxxxxxx
> 
> Signed-off-by: Andi Kleen <ak@xxxxxxx>
> 
> ---
>  arch/i386/kernel/microcode.c |    4 ----
>  1 files changed, 4 deletions(-)
> 
> Index: linux/arch/i386/kernel/microcode.c
> ===================================================================
> --- linux.orig/arch/i386/kernel/microcode.c
> +++ linux/arch/i386/kernel/microcode.c
> @@ -202,8 +202,6 @@ static inline void mark_microcode_update
>  	} else if (mc_header->rev == uci->rev) {
>  		/* notify the caller of success on this cpu */
>  		uci->err = MC_SUCCESS;
> -		printk(KERN_ERR "microcode: CPU%d already at revision"
> -			" 0x%x (current=0x%x)\n", cpu_num,
mc_header->rev, uci->rev);
>  		goto out;
>  	}
> 
> @@ -369,7 +367,6 @@ static void do_update_one (void * unused
>  	struct ucode_cpu_info *uci = ucode_cpu_info + cpu_num;
> 
>  	if (uci->mc == NULL) {
> -		printk(KERN_INFO "microcode: No new microcode data for
CPU%d\n",
>  		cpu_num);
>		return;
>  	}
> 
> @@ -511,7 +508,6 @@ static int __init microcode_init (void)  static
>  	void __exit microcode_exit (void)  {
> 	misc_deregister(&microcode_dev);
> -	printk(KERN_INFO "IA-32 Microcode
>  Update Driver v" MICROCODE_VERSION " unregistered\n"); }
> 
>  module_init(microcode_init)

How about changing the printk to pr_debug, other than removing them
completely?
This can facilitate debugging, as well as keeping normal log clean.

Thanks,
-Gordon
-
: send the line "unsubscribe linux-x86_64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html