Re: [PATCH] cfg80211: Fix for crash in cfg80211

[Johannes Berg <johannes@xxxxxxxxxxxxxxxx>]

On Tue, 2012-08-07 at 18:52 +0530, Mahesh Palivela wrote:

> >>                       dev->ethtools_ops is assigned during
> >> NETDEV_REGISTER and the same can be cleared during NETDEV_UNREGISTER.
> >
> > This doesn't make any sense to me at all.
> >
> cleanup of ethtools_ops pointer is required upon netdev_unreg 
> notification. we are assigning this pointer to cfg80211_ethtool_ops on 
> netdev_reg notification. Is it not required?
> 
> we have seen crash when keeping cfg80211 and mac80211 loaded and lmac 
> driver unloaded. With this fix, we didn't see crash. Crash doesn't 
> happen right away. Only when some operation trying to access ethtool_ops.

I don't see how anything could access ethtool_ops after the netdev is
unregistered.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html