Search Linux Wireless

Re: [PATCH 4/4] cfg80211: add cellular base station regulatory hint support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Fri, Jul 6, 2012 at 9:15 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Fri, 2012-07-06 at 09:07 -0700, Luis R. Rodriguez wrote:
>
>> > What I really wanted to know though is this: If the core code is
>> > enabled, what effect does receiving a "blessed" hint have on devices
>> > that don't set the flag? If there's no effect vs. an "unblessed" hint,
>> > then I think we don't need another option?
>>
>> Ah, OK so yes, as it is right now if the core accepts the hint but
>> devices do not listen to it we do have an effect right now which I
>> alluded to in my cover letter: country IE hints won't be listened to
>> after a base station hint gets accepted. Whether or not we want to
>> process country IE hints *after* a cell base station hint gets
>> accepted is debatable -- I decided that its easier to implement to
>> ignore country IE hints after a cell base station hint and I also
>> decided cell base station hints are likely something you'd prefer to
>> review over country IE hints. We can certainly change this and I'm
>> open to it.
>>
>> So yes, as it is right now if you enable onus but your device does not
>> support he feature you may detect a regression: country IE hints would
>> not be processed if you did receive a base station hint that the core
>> processed.
>
> It seems this might be a problem, in the case that I mentioned before:
> you do take all the necessary steps to enable this, but then somebody
> plugs in a USB device (say this is a tablet-like device?)

Agreed however see below.

> It seems it would be better to make the base station/country IE hint
> also depend on the feature flag?

Agreed, at first I figured this'd be complex to figure out dynamically
but it does not have to be: upon wiphy registration we could detect if
a device has the feature enabled and peg core_base_hint_enabled++ or
whatever and then allow them through. Upon deregistration we'd
core_base_hint_enabled-- and only enable the feature if its > 0.

Seems doable.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Kernel]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]     [Free Dating]     [M2M Wireless]

Add to Google Powered by Linux