Re: [RFC 06/17] nl80211: prepare for non-netdev wireless devs

[Johannes Berg <johannes@xxxxxxxxxxxxxxxx>]

On Mon, 2012-06-25 at 16:46 +0300, Eliad Peller wrote:

> > - * This structure must be allocated by the driver/stack
> > - * that uses the ieee80211_ptr field in struct net_device
> > - * (this is intentional so it can be allocated along with
> > - * the netdev.)
> > + * For netdevs, this structure must be allocated by the driver
> > + * that uses the ieee80211_ptr field in struct net_device (this
> > + * is intentional so it can be allocated along with the netdev.)
> > + * It need not be registered then as netdev registration will
> > + * be intercepted by cfg80211 to see the new wireless device.
> > + *
> it think you meant "it needs to be registered..." ?

Well, I should probably reword this, but I did actually mean that it
need not be registered (with cfg80211) if it has a netdev, because then
it must be registered as a netdev and "netdev registration will be
intercepted ..."

> > +       u32 identifier;

> > +       int devlist_generation, wdev_id;
> 
> it doesn't really matter, but why not define wdev_id with the same
> type as wdev->identifier?

I didn't even notice that, oops.

> > +       if (result)
> > +               return result;
> > +       return ERR_PTR(-ENODEV);
> 
> doesn't it remove the netns checks you've just added? :)

D'oh. Good point!

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html