RE: [RFC] {cfg,nl,mac}80211: 802.11ac changes

[Mahesh Palivela <maheshp@xxxxxxxxxxx>]

________________________________________
From: Johannes Berg [johannes@xxxxxxxxxxxxxxxx]
Sent: Wednesday, June 20, 2012 7:52 PM
To: Mahesh Palivela
Cc: linville@xxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx
Subject: Re: [RFC] {cfg,nl,mac}80211: 802.11ac changes

> +struct ieee80211_vht_capabilities {
> +     __le32 vht_capabilities_info;
> +     u8 vht_supported_mcs_set[8];

should have some define for that 8

[MP] Ok. 

> +} __attribute__((packed));

__packed

[MP] ok.

> +struct ieee80211_vht_operation {
> +     u8 vht_operation_information_chwidth;
> +     u8 vht_operation_information_chan_center_freq1;
> +     u8 vht_operation_information_chan_center_freq2;

That doesn't seem right? how can a center freq fit into a u8?

[MP] Its not center freq. Its center freq segment 1 and segment 2. I will change the names.

> +u8 *ieee80211_ie_build_vht_cap(u8 *pos, struct ieee80211_sta_vht_cap *vht_cap,
> +                                     u32 cap);

Please fix indentation.

[MP] ok.
> +     if (sband->vht_cap.vht_supported)
> +             pos = ieee80211_ie_build_vht_cap(pos, &sband->vht_cap,
> +                                             sband->vht_cap.cap);

ditto

There's some calculation about scan IE length somewhere -- I think that
needs to be adjusted? Or are you not using the info yet?

[MP] I will check that. I am using it. I tested my change and probe req comes out with VHT cap IE.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html