Re: [RFCv2 05/13] cfg80211: introduce cfg80211_get_chan_state
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Johannes Berg wrote:
On Wed, 2012-06-20 at 08:14 +0200, Michal Kazior wrote:Helper function for finding out which channel is used by a given interface. An exclusive channel can be used only by a single interface. This is mainly for non-fixed channel IBSS handling. Signed-off-by: Michal Kazior<michal.kazior@xxxxxxxxx> --- net/wireless/chan.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ net/wireless/core.h | 12 ++++++++++++ 2 files changed, 63 insertions(+), 0 deletions(-) diff --git a/net/wireless/chan.c b/net/wireless/chan.c index c1999e4..167e7cb 100644 --- a/net/wireless/chan.c +++ b/net/wireless/chan.c @@ -92,3 +92,54 @@ int cfg80211_set_monitor_channel(struct cfg80211_registered_device *rdev, return rdev->ops->set_monitor_channel(&rdev->wiphy, chan, chantype); } + +void +cfg80211_get_chan_state(struct cfg80211_registered_device *rdev, + struct wireless_dev *wdev, + struct ieee80211_channel **chan, + enum cfg80211_chan_mode *chanmode)Why not return the mode rather than void& pointer?
I think returning the mode would be ambiguous - the function name isn't "get_chan_mode". chan_mode isn't a result on its own. But then again, it's just a matter of preference.
-- Pozdrawiam / Best regards, Michal Kazior. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html