Search Linux Wireless

Re: [RFC 2/2] mac80211: support rssi threshold scan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/10/2012 01:03 AM, Pedersen, Thomas wrote:
> On Sat, Jun 09, 2012 at 10:09:52AM +0200, Johannes Berg wrote:
>> On Wed, 2012-06-06 at 19:43 -0700, Thomas Pedersen wrote:
>>
>>> +	if (sdata->local->scan_req->rssi &&
>>> +	    rx_status->signal < sdata->local->scan_req->rssi)
>>> +		return RX_DROP_MONITOR;
>>
>> I believe that should be RX_CONTINUE
> 
> Thanks. Since this is considered a performance optimization, it makes
> little sense to even implement it in mac80211?

It doesn't do any harm either and on the positive side the feature will
be tested with all mac80211 drivers. But other than that there's no real
advantage.

Well, there's a theoretical advantage once we implement partial scan
results which would avoid waking up user space unnecessary. But I doubt
it makes any difference in practise.

But I still vote to take this patch, just to make the feature supported
with a wider range of drivers.

Kalle
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux