Re: [PATCH] mac80211: ratelimit few aggregated messages

[Joe Perches <joe@xxxxxxxxxxx>]

On Thu, 2012-06-07 at 11:32 +0530, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <mohammed@xxxxxxxxxxxxxxxx>
> 
> ratelimit few aggregation related messages, these messages
> floods the log when aggregation is disabled in the AP(for some
> wifi testcases) and we run traffic between STA and AP.

I looked at all of the #ifdef CONFIG_MAC80211_HT_DEBUG uses.

I think it's better simply to define a mac80211_ht_dbg
macro for each of the !CONFIG and CONFIG cases and convert
all of the other #ifdef CONFIG_MAC80211_HT_DEBUG logging
messages.

#ifdef CONFIG_MAC80211_HT_DEBUG
#define mac80211_ht_dbg(fmt, ...)				\
	net_dbg_ratelimited(fmt, ##__VA_ARGS__)
#else
#define mac80211_ht_dbg(fmt, ...)				\
do {								\
	if (0)							\
		net_dbg_ratelimited(fmt, ##__VA_ARGS__);	\
} while (0)

etc...

I think there's one use of wiphy_dbg that could be a
mac80211_ht_dbg without much loss.

Maybe add "%s", wiphy_name() to the args there.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html