Re: [PATCH 3/3] mwifiex: fix kernel warning in ibss start/join path

[Johannes Berg <johannes@xxxxxxxxxxxxxxxx>]

On Wed, 2012-05-16 at 21:24 -0700, Bing Zhao wrote:
> From: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
> 
> Since cfg80211_ibss_joined() is called inside ibss join callback
> routine, following kernel warning is hit while starting/joining
> an ibss network.
> 
> "WARNING: at net/wireless/ibss.c:63 cfg80211_ibss_joined+0x35/0xb6
> [cfg80211]()"
> 
> Update "wdev->ssid" and "wdev->ssid_len" in ibss join callback to
> fix this warning.

Guys, no. The documentation for this explicitly says:

 * @ssid: (private) Used by the internal configuration code
 * @ssid_len: (private) Used by the internal configuration code

Don't touch it. I knew I should have hidden these fields from driver
view, but it wasn't easily possible.

If you're using the API wrong then you should fix that instead. In
particular, you should only call cfg80211_ibss_joined() when you
actually know the BSSID of the IBSS you've joined. You can't possibly
know this at this point since you can't even have scanned for peers yet.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html