Re: [PATCH] mwl8k: Add 0x2a02 PCI device-id (Marvell 88W8361)
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
On 05/01/2012 03:54 PM, Sedat Dilek wrote:
On Tue, May 1, 2012 at 2:51 PM, Lennert Buytenhek <buytenh@xxxxxxxxxxxxxx> wrote:On Sun, Apr 29, 2012 at 12:25:21AM +0200, Sedat Dilek wrote:On 1st sight, logs look fine: [21:52:52]<lautriv> [ 6.050967] ieee80211 phy0: 88w8361p v4, 00173f3bdde3, STA firmware 184.108.40.206 But WLAN connection is not that fast and stable as lautriv reports (several abnormalities were observed). I requested a tarball which includes: * dmesg (Linux-3.3.3) * e_n_a (/etc/network/interfaces) * ifconfig output * iwconfig output * iw_phy output * ps_axu (WPA) output lautriv will be so kind to be around on #linux-wireless/Freenode the next days (UTC+2: German/Swiss local-time). Just ping him. Hope you have fun, together! - Sedat -A new tarball from lautriv with same outputs as before, but now tested with Linux-3.4-rc4.[ CC hauke (OpenWrt) and Ben Hutchings (linux-firmware maintainer) ]The output looks good enough for me to ACK adding the PCI ID. Can the firmware being used here be submitted to the linux-firmware git tree?I can't say much about the firmware  inclusion or the procedure of it into linux-firmware . Maybe, Ben can explain the procedure and what has to be considered before inclusion in linux-firmware. The original firmware and helper images were extracted from a Netgear Windows driver . From what I read in the OpenWrt forum posting : You wanted to care for inclusion: "Firmware isn't included in the kernel tree anymore, there's the linux-firmware git tree for that these days. I will contact some people at Marvell to ask whether 8361P firmware can be included there."
Basically, all firmware in linux-firmware repository should be accompanied with license information. Also you are signing off the patch to add the firmware to the repository so you are bound to the Developer's Certificate of Origin 1.1 in . Having the firmware extracted from a windows driver does not fall under that statement, unless Marvell is ok with its redistribution. Recently a patch was submitted for a README in the linux-firmware repository about the process. It must be a binary patch. Easiest way is to use 'git format-patch -B'.
Gr. AvS  http://lxr.linux.no/linux+v3.3.4/Documentation/SubmittingPatches  https://lkml.org/lkml/2012/4/21/177 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html