Search Linux Wireless

Re: [PATCH v2 0/6] BCMA Cumulative patches from OpenWRT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


"Arend van Spriel" <arend@xxxxxxxxxxxx> writes:

> On 04/26/2012 06:23 AM, Nathan Hintz wrote:
>> Nathan Hintz (6):
>>    bcma: Find names of non BCM cores
>>    bcma: Move initialization of SPROM to prevent overwrite
>>    bcma: Account for variable PCI memory base/size
>>    bcma: reads/writes are always 4 bytes, so always map 4 bytes
>>    bcma: Add __devexit to bcma_host_pci_remove
>>    bcma: Add flush for BCMA_RESET_CTL write
>>
>>   arch/mips/bcm47xx/setup.c      |    4 +++
>>   arch/mips/bcm47xx/sprom.c      |    2 -
>>   drivers/bcma/core.c            |    1 +
>>   drivers/bcma/driver_pci_host.c |   10 +++---
>>   drivers/bcma/host_pci.c        |    4 +-
>>   drivers/bcma/scan.c            |   54 +++++++++++++++++++++++++++++----------
>>   6 files changed, 52 insertions(+), 23 deletions(-)
>>
>
> None of these patches have any description. Some motivation for the
> changes would be appreciated like 'reported problem', 'new target
> support', etc.

I would say that it's required. Anyone can see the diff and see what was
changed, but nobody will figure out why the change was made unless it's
described in the commit log. So it's important to answer the question
"Why?".

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Kernel]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]     [Free Dating]     [M2M Wireless]

Add to Google Powered by Linux