Re: [PATCH 3/6] bcma: Account for variable PCI memory base/size

[Florian Fainelli <florian@xxxxxxxxxxx>]

Hi Nathan,

Le 04/25/12 08:15, Nathan Hintz a écrit :
> ---
>   drivers/bcma/driver_pci_host.c |    5 +++--
>   1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bcma/driver_pci_host.c b/drivers/bcma/driver_pci_host.c
> index d2097a1..3578e1a 100644
> --- a/drivers/bcma/driver_pci_host.c
> +++ b/drivers/bcma/driver_pci_host.c
> @@ -491,8 +491,9 @@ void __devinit bcma_core_pci_hostmode_init(struct bcma_drv_pci *pc)
>   	/* Ok, ready to run, register it to the system.
>   	 * The following needs change, if we want to port hostmode
>   	 * to non-MIPS platform. */
> -	io_map_base = (unsigned long)ioremap_nocache(BCMA_SOC_PCI_MEM,
> -						     0x04000000);
> +	io_map_base = (unsigned long)ioremap_nocache(pc_host->mem_resource.start,
> +						     pc_host->mem_resource.end -
> +						     pc_host->mem_resource.start + 1);

Please use resource_size(pc_host->mem_resource) instead of open-coding 
the size computation here.

>   	pc_host->pci_controller.io_map_base = io_map_base;
>   	set_io_port_base(pc_host->pci_controller.io_map_base);
>   	/* Give some time to the PCI controller to configure itself with the new
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html