Re: [PATCH] watchdog: iTCO_wdt: Fix the parent device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 10, 2014 at 09:28:17PM +0100, Jean Delvare wrote:
> The watchdog's parent is iTCO_wdt (the platform device) not lpc_ich
> (the PCI device.) Setting the parent right makes it much easier for
> the user to figure out which driver/module is handling the watchdog
> device node.
> 
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Wim Van Sebroeck <wim@xxxxxxxxx>

Makes sense to me.

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/iTCO_wdt.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-3.14-rc5.orig/drivers/watchdog/iTCO_wdt.c	2014-01-20 03:40:07.000000000 +0100
> +++ linux-3.14-rc5/drivers/watchdog/iTCO_wdt.c	2014-03-08 13:56:01.905564783 +0100
> @@ -485,7 +485,7 @@ static int iTCO_wdt_probe(struct platfor
>  	iTCO_wdt_watchdog_dev.bootstatus = 0;
>  	iTCO_wdt_watchdog_dev.timeout = WATCHDOG_TIMEOUT;
>  	watchdog_set_nowayout(&iTCO_wdt_watchdog_dev, nowayout);
> -	iTCO_wdt_watchdog_dev.parent = dev->dev.parent;
> +	iTCO_wdt_watchdog_dev.parent = &dev->dev;
>  
>  	/* Make sure the watchdog is not running */
>  	iTCO_wdt_stop(&iTCO_wdt_watchdog_dev);
> 
> 
> -- 
> Jean Delvare
> SUSE L3 Support
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux