Re: [PATCH] watchdog: intel_scu_watchdog: Remove unused variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 15, 2014 at 01:22:18PM +0400, Alexander Shiyan wrote:
> Variable "hw_pre_value" is not used anywhere in the
> function intel_scu_set_heartbeat().
> This patch removes this variable.
> 
> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/intel_scu_watchdog.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/intel_scu_watchdog.c b/drivers/watchdog/intel_scu_watchdog.c
> index e13e65e..0caab62 100644
> --- a/drivers/watchdog/intel_scu_watchdog.c
> +++ b/drivers/watchdog/intel_scu_watchdog.c
> @@ -211,7 +211,6 @@ static int intel_scu_set_heartbeat(u32 t)
>  	int			 ipc_ret;
>  	int			 retry_count;
>  	u32			 soft_value;
> -	u32			 hw_pre_value;
>  	u32			 hw_value;
>  
>  	watchdog_device.timer_set = t;
> @@ -273,8 +272,7 @@ static int intel_scu_set_heartbeat(u32 t)
>  			watchdog_device.timer_load_count_addr);
>  
>  		/* read count value before starting timer */
> -		hw_pre_value = ioread32(watchdog_device.timer_load_count_addr);
> -		hw_pre_value = hw_pre_value & 0xFFFF0000;
> +		ioread32(watchdog_device.timer_load_count_addr);
>  
>  		/* Start the timer */
>  		iowrite32(0x00000003, watchdog_device.timer_control_addr);
> -- 
> 1.8.3.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux