Re: [PATCH 01/10] watchdog: xilinx: Convert driver to the watchdog framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/31/2014 06:18 AM, Michal Simek wrote:
- Remove uneeded headers, fops functions
- Use xilinx_wdt prefix in start/stop/keepalive functions
   and in new structures

Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>

Hi Michal,

  static int xwdt_probe(struct platform_device *pdev)
  {
  	int rc;
@@ -314,7 +184,7 @@ static int xwdt_probe(struct platform_device *pdev)
  					"xlnx,wdt-enable-once", NULL);
  	if (tmptr == NULL) {
  		pr_warn("Parameter \"xlnx,wdt-enable-once\" not found in device tree!\n");
-		xdev.nowayout = WATCHDOG_NOWAYOUT;
+		watchdog_set_nowayout(&xilinx_wdt_wdd, true);

Sure you want to set this to always true instead of using WATCHDOG_NOWAYOUT ?

Assuming this is what you want:

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux