Re: [PATCH RESEND V3 0/3] Watchdog: OMAP3: bootstatus fix and changes for the current watchdog framework

["zumeng.chen" <zchen@xxxxxxxxxxxxx>]

On 2012年07月16日 21:10, Hiremath, Vaibhav wrote:
> On Sun, Jul 15, 2012 at 13:14:03, Zumeng Chen wrote:
> > Hello,
> >
> > The following patches based on the 3.5-rc6 from Wim, which
> > focus on:
> >
> > 1. bootstatus fix for omap3,
> >
> > 2. omap-wdt framework update cater for the current framework
> >     as Shubhrajyoti comments mentioned.
> >
> > V3 changes:
> >
> > 1. New comments updated as Kevin mentioned in the third patch;
> > 2. 3530evm works well,
> >     AM33xx seems work well with the following changes:
> > 	+   if (cpu_is_am335x())
> > 	+       return omap2_prm_read_mod_reg(AM33XX_PRM_DEVICE_MOD,
> > 	+           AM33XX_PRM_RSTST_OFFSET)&  0x7f;
> >     But since some definitions not ready for am33xx, so I don't
> >     give the patch, if they have been updated, feel free to take these.
> Did you test it on any of AM33xx platform?
Yes. I ever did in v2 as follows shown:

The same case works well on am335xevm but with a new patch in
mach-omap2/prcm.c

I'll send it later.

root@ti-omap3:~# uname -a
Linux ti-omap3 3.4.3-00635-g82d1d26-dirty #32 Wed Jul 11 16:02:12 CST
2012 armv7l GNU/Linux
root@ti-omap3:~# dmesg|grep WDT
[ 1.921173] omap_wdt: OMAP WDTimer Rev 0x01: Initial timeout 0sec status= 0x1
root@ti-omap3:~# ./a.out -i 20; for i in `seq 1 20`; do echo $i ; sleep
1;done
Set watchdog interval to 20
Current watchdog interval is 20
Last boot is caused by : Watchdog
Use:
<w>  to kick through writing over device file
<i>  to kick through IOCTL
<x>  to exit the program
x

1
2
[snip]
U-Boot SPL 2011.09 (Feb 09 2012 - 15:38:59)
Texas Instruments Revision detection unimplemented


U-Boot 2011.09 (Feb 09 2012 - 15:11:31)

I2C: ready
DRAM: 256 MiB
WARNING: Caches not enabled
Found a daughter card connected
NAND: HW ECC Hamming Code selected
256 MiB
MMC: OMAP SD/MMC: 0
Net: cpsw
Hit any key to stop autoboot: 0
U-Boot#


>   If you use linux-omap/master pr
> linux-next branch as a baseline you should have basic things (except hwmod
> data) available.
>
> I will test it and send a patch for this on your behalf (if you are ok with
> it).
I'm OK for this, thanks Vaibhav.
> Note: Change in convention, cpu_is_am335x() =>  soc_is_am335x()
Yes, agreed.

Regards,
Zumeng
> Thanks,
> Vaibhav

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html