Re: [PATCH 3/4] watchdog: dev: don't enforce set_timeout()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi Wolfram,

> On Thu, Feb 02, 2012 at 06:48:10PM +0100, Wolfram Sang wrote:
> > Some watchdogs rewrite the timer on every ping, so they don't need a specific
> > set_timeout callback. Allow the callback to be empty for such devices.
> > 
> > Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> 
> Wim, I saw that the first two patches are in linux-next, but not this and the
> following one? Any remarks?

first 2 patches are in indeed, but the 4th one (with some adoptions because I left
3 out) is also in. I have to look at patch 3 again, but I gave priority to Hans his
patch nr 4: watchdog_dev: Let the driver update the timeout field on set_timeout
success. Some device indeed don't have a 1 second resolution. That's why it should
be the drivers responsibility to update the code.

But on the other hand, you also are right to say that a lot of drivers just will do:

static int wdt_set_timeout(struct watchdog_device *wdd, unsigned timeout)
{
	wdd->timeout = timeout;
	retun 0;
}

For this we can add a helper or adjust the watchdog code to do this as default.
I have to check out what the best solution is.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Site Home]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Tools]     [DDR & Rambus]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

Add to Google