Re: [PATCH v3] watchdog: Convert jz4740_wdt driver to watchdog core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, Jan 26, 2012 at 06:10:45PM +0800, Axel Lin wrote:
> This patch converts jz4740_wdt driver to use watchdog core APIs.
> Also use devm_* APIs to save a few error handling code.
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> Acked-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> ---
> v3: - Remove unused define for WDT_IN_USE and WDT_OK_TO_CLOSE
>     - Remove mem from struct jz4740_wdt_drvdata
> 
> v2: Address all the comments by Wolfram.
>     - Remove unneed header file inclusion
>     - Drop 'heartbeat' usage in jz4740_wdt_set_heartbeat and jz4740_wdt_start
>     - Init wdt_dev->timeout in probe using the global 'heartbeat'
>     - Remove unneed pointer check for drvdata->mem

Reviewed-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>

Thanks!

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature


[Site Home]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Tools]     [DDR & Rambus]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

Add to Google