RE: [RFC PATCH v2] watchdog: ep93xx: Use the WatchDog Timer Driver Core.
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On Thursday, August 04, 2011 11:13 AM, Mika Westerberg wrote: > On Wed, Aug 03, 2011 at 10:21:26AM -0700, H Hartley Sweeten wrote: >> Convert the ep93xx watchdog driver to using the WatchDog Timer Driver Core. >> >> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> >> Cc: Wim Van Sebroeck <wim@xxxxxxxxx> >> Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > > Tested-by: Mika Westerberg <mika.westerberg@xxxxxx> > > BTW, now that the driver uses watchdog core should we also select > WATCHDOG_CORE in the Kconfig? If it is not enabled we get: > > drivers/built-in.o: In function `ep93xx_wdt_init': > clkdev.c:(.init.text+0x2bd8): undefined reference to > `watchdog_register_device' > make: *** [.tmp_vmlinux1] Error 1 > > Other than that, you can also add my > > Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxx> > > if you like. Mika, I just posted a v3 of this patch that includes the Kconfig change to select WATCHDOG_CORE. Can you please take a look and possibly test it? After that I'll add your Tested-by and Reviewed-by tags. Thanks, Hartley-- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html