- To: Eric Northup <digitaleric@xxxxxxxxxx>
- Subject: Re: [RFC-v5] tcm_vhost: Initial merge for vhost level target fabric driver
- From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
- Date: Wed, 01 Aug 2012 08:42:36 +0200
- Cc: Jens Axboe <axboe@xxxxxxxxx>, Anthony Liguori <aliguori@xxxxxxxxxx>, linux-scsi <linux-scsi@xxxxxxxxxxxxxxx>, kvm-devel <kvm@xxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, qemu-devel <qemu-devel@xxxxxxxxxx>, lf-virt <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Anthony Liguori <aliguori@xxxxxxxxxxxxxxxxxx>, target-devel <target-devel@xxxxxxxxxxxxxxx>, Zhi Yong Wu <wuzhy@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxxxxxxxxxx>
- Delivered-to: virtualization@xxxxxxxxxxxxxxxxxxxxxxxx
- In-reply-to: <CAG7+5M35QAK=ggAJRZtga0PWw5VZFi-mraKEAkWiq16U3ysxjg@mail.gmail.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
Il 31/07/2012 22:52, Eric Northup ha scritto:
> It seems to me like this is not the way that virtio devices are supposed
> to behave - if a guest splits a virtio_scsi_cmd_req or _resp across a
> page boundary, then this code won't work.
Buffers can cover several pages. Of course, data buffers have to be at
least sector aligned, but this restriction does not apply to
request/response descriptors.
> Quoting the 'Message Framing' part of the virtio spec:
>
> "In particular, no implementation should use the descriptor boundaries
> to determine the size of any header in a request. "
True, but this has never matched reality.
Paolo
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[KVM Development]
[CentOS Virtualization]
[Netdev]
[Ethernet Bridging]
[Linux Wireless]
[Kernel Newbies]
[Security]
[Linux for Hams]
[Netfilter]
[Bugtraq]
[Photo]
[Yosemite]
[Yosemite Forum]
[MIPS Linux]
[ARM Linux]
[Linux RAID]
[Linux Admin]
[Samba]
[Find Someone Nice]
[Video 4 Linux]
[Linux Resources]