- To: Sasha Levin <levinsasha928@xxxxxxxxx>
- Subject: Re: [net-next RFC V5 2/5] virtio_ring: move queue_index to vring_virtqueue
- From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
- Date: Thu, 26 Jul 2012 10:20:02 +0200
- Cc: krkumar2@xxxxxxxxxx, habanero@xxxxxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, mst@xxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, mashirle@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, edumazet@xxxxxxxxxx, tahm@xxxxxxxxxxxxxxxxxx, jwhan@xxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, sri@xxxxxxxxxx
- Delivered-to: virtualization@xxxxxxxxxxxxxxxxxxxxxxxx
- In-reply-to: <1341488454.18786.15.camel@lappy>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
Il 05/07/2012 13:40, Sasha Levin ha scritto:
> @@ -275,7 +274,7 @@ static void vm_del_vq(struct virtqueue *vq)
> vring_del_virtqueue(vq);
>
> /* Select and deactivate the queue */
> - writel(info->queue_index, vm_dev->base + VIRTIO_MMIO_QUEUE_SEL);
> + writel(virtqueue_get_queue_index(vq), vm_dev->base + VIRTIO_MMIO_QUEUE_SEL);
> writel(0, vm_dev->base + VIRTIO_MMIO_QUEUE_PFN);
>
This accesses vq after vring_del_virtqueue has freed it.
Paolo
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[KVM Development]
[CentOS Virtualization]
[Netdev]
[Ethernet Bridging]
[Linux Wireless]
[Kernel Newbies]
[Security]
[Linux for Hams]
[Netfilter]
[Bugtraq]
[Photo]
[Yosemite]
[Yosemite Forum]
[MIPS Linux]
[ARM Linux]
[Linux RAID]
[Linux Admin]
[Samba]
[Find Someone Nice]
[Video 4 Linux]
[Linux Resources]