Re: [PATCH] virtio_balloon: fix towards_target when deflating balloon

Rusty Russell <rusty@xxxxxxxxxxxxxxx> · Tue, 19 Aug 2008 11:22:54 +1000

On Tuesday 19 August 2008 08:15:31 Anthony Liguori wrote:
> -	return v - vb->num_pages;
> +	if (v < vb->num_pages)
> +		return -(s64)(vb->num_pages - v);
> +	else
> +		return v - vb->num_pages;

With all due respect, WTF?

Did you mean:

	return (s64)v - vb->num_pages;

I'm really amazed this bug got this far though...
Rusty.
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization