Re: [PATCH 7/9] usb/gadget: remove bufsiz from struct usb_composite_dev

[Michal Nazarewicz <mina86@xxxxxxxxxx>]

Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> writes:
> there is no read user of bufsiz, its content is available via
> USB_COMP_EP0_BUFSIZ. Remove it.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>

> ---
>  drivers/usb/gadget/composite.c |    1 -
>  include/linux/usb/composite.h  |    2 --
>  2 files changed, 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index e380a05..0f548fe 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -1449,7 +1449,6 @@ static int composite_bind(struct usb_gadget *gadget,
>  	cdev->req->complete = composite_setup_complete;
>  	gadget->ep0->driver_data = cdev;
>  
> -	cdev->bufsiz = USB_COMP_EP0_BUFSIZ;
>  	cdev->driver = cdriver;
>  
>  	/*
> diff --git a/include/linux/usb/composite.h b/include/linux/usb/composite.h
> index 89d91b6..e970fba 100644
> --- a/include/linux/usb/composite.h
> +++ b/include/linux/usb/composite.h
> @@ -318,7 +318,6 @@ extern void usb_composite_setup_continue(struct usb_composite_dev *cdev);
>   * struct usb_composite_device - represents one composite usb gadget
>   * @gadget: read-only, abstracts the gadget's usb peripheral controller
>   * @req: used for control responses; buffer is pre-allocated
> - * @bufsiz: size of buffer pre-allocated in @req
>   * @config: the currently active configuration
>   *
>   * One of these devices is allocated and initialized before the
> @@ -349,7 +348,6 @@ extern void usb_composite_setup_continue(struct usb_composite_dev *cdev);
>  struct usb_composite_dev {
>  	struct usb_gadget		*gadget;
>  	struct usb_request		*req;
> -	unsigned			bufsiz;
>  
>  	struct usb_configuration	*config;
>  
> -- 
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--

Attachment: pgpu0KxAlMKlD.pgp
Description: PGP signature